Skip to content

feat: add proof-of-concept implementation for strict fully validating using draft-06 schema #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

feat: add proof-of-concept implementation for strict fully validating using draft-06 schema #835

wants to merge 43 commits into from

Conversation

DannyvdSluijs
Copy link
Collaborator

@DannyvdSluijs DannyvdSluijs commented Jun 25, 2025 •
edited
Loading

This PR will:

  • Introduce the JsonSchema\Constraints\Drafts\Draft06 namespace
  • A constraint per keyword
  • Enable the draft6 in the test, locally I have 633 passing test, 312 failing tests and 157 ignored tests.

Update 22-08-2025:

This PR has progressed nicely over time with a minimal impact on existing code. I'm currently trying to resolve the remaining issues from the pipeline (tests, style and static analysis) as well as fix quick wins/hardcoded solutions specific for Draft06

@DannyvdSluijs
Copy link
Collaborator Author

Locally I now have 754 passing test, 213 failing tests and 135 ignored tests.

@DannyvdSluijs DannyvdSluijs mentioned this pull request Jun 26, 2025
Closed
@DannyvdSluijs
Copy link
Collaborator Author

Locally I now have 754 passing test, 213 failing tests and 135 ignored tests.

Now 773 passing, 207 failing and 122 ignored

@DannyvdSluijs
Copy link
Collaborator Author

DannyvdSluijs commented Jun 27, 2025 •
edited
Loading

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

@DannyvdSluijs DannyvdSluijs force-pushed the draft-06-support branch 3 times, most recently from a5fc2ea to 1861371 Compare July 1, 2025 17:54
@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

1049 passing, 20 failing and 33 ignored

@DannyvdSluijs
Copy link
Collaborator Author

Now 773 passing, 207 failing and 122 ignored

849 passing, 181 failing and 72 ignored

886 passing, 145 failing and 71 ignored

953 passing, 78 failing and 71 ignored

961 passing, 70 failing and 71 ignored

978 passing, 69 failling and 55 ignored

991 passing, 56 failling and 55 ignored

1025 passing, 20 failing and 57 ignored

1049 passing, 20 failing and 33 ignored

1075 passing, 20 failing and 7 ignored

@DannyvdSluijs
feat: add proof-of-concept implementation for strictfully validating …
3948340 
…using draft-06 schema
@DannyvdSluijs
feat: more progress on draft-06 proof of concept
6f45bb3
@DannyvdSluijs
feat: more support on draft-06 schema
92d117e
@DannyvdSluijs
feat: Fixing multiple of; Removing dedicated draft-06 test case
2cdb35f
@DannyvdSluijs
fix: restore number constraint for draft-03 and draft-04
86c1ebd
@DannyvdSluijs
feat: add more support for draft06 schema
4a21d75
@DannyvdSluijs
feat: add more support for draft 06
e97f2f1
@DannyvdSluijs
feat: add more draft-06 support
3b3db3a
@DannyvdSluijs
feat: more support for draft-06
a4348c9
@DannyvdSluijs
style: correct code style violations
b430d9c
@DannyvdSluijs
refactor: resolve phpstan found issues
2ebdec9
@DannyvdSluijs
feat: more support for draft-06
09fa099
@DannyvdSluijs
fix: resolve dependencies keyword for oject with subschema
3565e29
@DannyvdSluijs
feat: add support for $ref
fd82060
@DannyvdSluijs
fix: Fix multiple off implementation
ba27d2e
DannyvdSluijs and others added 19 commits August 29, 2025 12:59
@DannyvdSluijs
feat: Improving on format keyword
cc7f338
@DannyvdSluijs
fix: Resolve failling test cases for format hostname
528d97e
@DannyvdSluijs
fix: add handling of uri-template format; fail on backslash in uri re…
221cb87 
…ference
@DannyvdSluijs
style: correct code style violations
3c98180
@DannyvdSluijs
fix: fix optional regex testcase for ecmascript support
6fd8399
@DannyvdSluijs
refactor: Correct type hints in MultipleOf
06e1b11
@DannyvdSluijs
refactor: correct more PHPStan discoverd issues
4fc3b30
@DannyvdSluijs
fix: fix edge cases with $ref
bf9bf22
@DannyvdSluijs
refactor: improve any of error messages
3e164de
@DannyvdSluijs
test: Skip same test for draft 6
05d0eb0
@DannyvdSluijs
style: Correct code style violations
6e3d3cc
@DannyvdSluijs
refactor: resolve PHPStan errors
181d647
@DannyvdSluijs
fix: resolve phpstan errors
5023f95
@DannyvdSluijs
style: correct code style violations
4efe199
@DannyvdSluijs
test: Block failling test which where blocked in previous drafts as well
5a99b87
@DannyvdSluijs
refactor: Resolce PHPStan issues in MultipleOfConstraint
cc6e702
@DannyvdSluijs
refactor: Resolve PHPStan issues from Rfc3339
0f6df8b
@DannyvdSluijs
style: Correct code style violations
32c6540
@DannyvdSluijs
refactor: Resolve hadrcoded draft6 solutions
8dff21a
This was referenced Aug 29, 2025
Closed
Closed
Open
@DannyvdSluijs
refactor: Introduce DraftIdentifers enum
77156cd
@DannyvdSluijs
test: Skip remaining failing testcases
90cbbe6 
These test cases are complex edge cases which perhaps no one will ever use. Rather haft support for draft 6 supporting the vast majority instead of being 100% complete somewhere in the future.
@DannyvdSluijs
style: Correct code style violations
2b489ea
@DannyvdSluijs
style: Correct PHPStan found errors
7b3c2c2
@DannyvdSluijs
fix: Add draft 6 remapping to json schema draft on disk
94d2da8
@DannyvdSluijs DannyvdSluijs marked this pull request as ready for review August 29, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyvdSluijs @matason